Skip to content

branch-4.0: [fix](fe) Preserve operative slots when deep copying logical relations #63315#63708

Open
github-actions[bot] wants to merge 1 commit into
branch-4.0from
auto-pick-63315-branch-4.0
Open

branch-4.0: [fix](fe) Preserve operative slots when deep copying logical relations #63315#63708
github-actions[bot] wants to merge 1 commit into
branch-4.0from
auto-pick-63315-branch-4.0

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Cherry-picked from #63315

#63315)

problem summary: 

When deep copying a `LogicalCatalogRelation`,
`LogicalPlanDeepCopier#updateOperativeSlots` needs to remap the original
relation's operative slots to the corresponding slots in the copied
relation.

Before this change, the search range was incorrectly limited by
`oldOperativeSlots.size()` instead of the relation output size. If the
operative slot was not located in the first `oldOperativeSlots.size()`
output positions, the copier could not find the matching slot and the
copied relation would lose that operative slot.

For example, when a relation has multiple output slots but only one
operative slot at index 1, the old logic only checked index 0 and failed
to preserve the operative slot.

Co-authored-by: yangtao555 <yangtao555@jd.com>
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants